optionValueField with double => strange behavior => bug?

TobMei · November 1, 2020, 8:42pm

Hi!

I’m using Neos Flow 6.0.6. I would like to use the optionValueField-tag in my select-field.

<f:form.select property=“blubb” options=“{blub}” optionValueField=“price” />

When “getPrice()” returns a double value, the select form shows only one option and the value of the option is “1”. In my case, the double value was “1.36”. So, the “1” could be a rounded value.

When I’m using the function

getOptionValue() { return (string)$this->price; }

and

<f:form.select property=“blubb” options=“{blub}” optionValueField=“optionValue” />

everything is fine.

Is this a kind of bug or a feature?!

Thanks for your help!

Best regards,

Tobias

aberl · November 2, 2020, 2:16pm

That’s… a bug

github.com

neos/flow-development-collection/blob/5.3/Neos.FluidAdaptor/Classes/ViewHelpers/Form/SelectViewHelper.php#L240-L254


      
          $key = ObjectAccess::getPropertyPath($value, $this->arguments['optionValueField']);
          if (is_object($key)) {
              if (method_exists($key, '__toString')) {
                  $key = (string)$key;
              } else {
                  throw new ViewHelper\Exception(
                      sprintf(
                          'Identifying value at path "%s" for %s was an object.',
                          $this->arguments['optionValueField'],
                          is_object($value) ? 'object of class "' . get_class($value) . '"' : 'array'
                      ),
                      1247827428
                  );
              }
          }

We only expect the value from optionValueField to be a string or an object that can be __toString()'d - so we effectively forgot it could be a (decimal)number.

TobMei · November 2, 2020, 4:00pm

Yes, it’s happened - I’ve found a bug I’ve been of the opinion dozens of times that this must be a bug, but it was due to my unknowing
Do I still have to report it officially somewhere?

sorenmalling · November 3, 2020, 10:11am

Please add it as a issue on Sign in to GitHub · GitHub

TobMei · November 8, 2020, 6:34pm

Done. Thank you!

bwaidelich · November 10, 2020, 1:32pm

Link Bot: https://github.com/neos/flow-development-collection/issues/2225

sorenmalling · November 11, 2020, 10:05am

And thank you If you want to be sure it will be fixed in for next release, you can provide a patch for it Find information on these links

https://docs.neos.io/cms/contributing-to-neos/

Development workflow for GitHub

or join the Slack channel neos-project.slack.com/