Asset replacement, filenames and MIME type

kdambekalns · July 27, 2021, 7:19am

I recently created an issue:

github.com/neos/neos-development-collection

Replacing an asset with a different type and "keep filename" is broken

opened 03:45PM - 30 Jun 21 UTC

closed 09:07PM - 23 Mar 22 UTC

kdambekalns

P: Media Bug

### Description Replacing an asset with an asset of a different type (e.g. an… SVG with a PNG) works fine unless the option to keep the original filename is used. ### Steps to Reproduce 1. Upload an SVG asset 2. Replace that asset with a PNG and check "Keep the filename …" #### Expected behavior The asset is replaced and the type reflects what has been uploaded, regardless of the original filename. #### Actual behavior The type is left unchanged, leading to errors for operations that rely on that type (e.g. thumbnail rendering). ### Affected Versions Neos: 7.1.0 (and probably earlier) Flow: 7.1.0 (and probably earlier)

and followed that up with a PR:

github.com/neos/neos-development-collection

BUGFIX: Use media type of new resource during asset replacement

neos:5.3 ← kdambekalns:bugfix/3365-media-type-resource-replace

opened 04:08PM - 30 Jun 21 UTC

kdambekalns

+11 -1

When the resource of an asset is replaced but the filename kept, the media type… of the new asset is replaced by whatever the original filename indicates. This change fixes that by re-setting the media type from the new resource after the original filename has been set. Fixes #3365

Now there is a problem remaining that needs a decision to be solved reliably:

There needs to be a decision whether to prohibit the replacement for non-matching mime-types or whether to change the file extension on-the-fly.

(see BUGFIX: Use media type of new resource during asset replacement by kdambekalns · Pull Request #3366 · neos/neos-development-collection · GitHub)

What should we do when an editor replaces a resource with a new one having a different MIME type than before?

prohibit replacements
change file extension
do nothing

0 voters

bwaidelich · July 27, 2021, 7:24am

Wouldn’t that mean that I can replace an image by a pdf, potentially breaking node properties that only support images?

sebobo · July 27, 2021, 7:32am

It would be nice to be able to replace a png logo/icon by a svg version for example.

christianm · July 27, 2021, 7:34am

Yep, there are definitely some valid cases and many invalid cases for this…

kdambekalns · July 27, 2021, 8:36am

Use cases exist, and my fix makes sure the MIME type in the database is correctly set. But a webserver using the file extension to determine the MIME type is (still) fooled by this, leading to errors.

The main question probably is: Does changing the extension break the expectation of “keep the existing filename”?

bwaidelich · July 29, 2021, 7:20am

It’s certainly nice to be able to replace images, but I would suggest a different process for this.
Instead of saying “this png is now a svg” (or even a pdf) we could provide a better “usages” view that allows for (batch) updating properties of affected nodes for example.
This way the node type validation would still be respected and you’d have more control over it.

Replacing the asset itself feels a bit like changing a user entity completely while keeping its id

sebobo · July 29, 2021, 7:37am

One thing to remember: currently when the redirecthandler is installed it will also create a redirect if “keep the existing filename” is not set. When we still change the extension if it’s set, then we also have to adjust the redirect creation behaviour for that case.

IMO the most pragmatic thing is doing exactly that.
That we create a special view to replace assets sounds too far into the future

kdambekalns · October 15, 2021, 4:50pm

Ok, changing the extension it is…