during our nice sprint in Hamburg, we have had some ideas on how to tackle the 150+ pull requests in our project.
We had the discussion, and ended up with the following points ( - not exhaustive; as far as I can remember) :
Longtime contributors in the Team have big experience on many areas of the code, thus they are required for doing many code reviews.
However, some of the $longtime contributors (such as me) don’t do many code reviews, also due to involvement in other big areas.
The newer Neos team members are still lacking experience in many|some code-areas; that’s why it’s a hard task for doing code reviews there.
Suggestion
The suggestion we came up with is the following:
We do “pairing” code review sessions between long-term and newer team members, as an effort to share the load, have a learning experience and social interaction, creating more fun along the process.
I’d aim for at most one hour of pairing code review per week and person.
Next Steps
Everybody who considers himself as experienced and volunteers for pairing/coaching, please let me know on Slack.
Then, we’ll announce review spots; and try to match others who’d like to learn the review process
Thanks to push the pair programming, I’m in at 100%, and will try to block to fixed 1 hour session per week, one during work hour and one in the evening or saturday depending on the needs.
I’ll do the first open review session at Wednesday, 30.11. between 14:00 and 15:00 (UTC + 1 == Europe/Berlin) via google hangouts.
If you want to attend:
please like this post so I know you’ll be attending.
please have some code reviews ready you’d like to go through together with me.
We’ll basically do code reviews for the full hour; see how many we get done during this timeframe.
All the best,
Sebastian
PS: Of course this is open for team members as well as non-team-members
PPS: @mentors: Please announce the time slots you have available for mentoring here.
:
