Fluid Standalone Pull Request - Help for Testing Needed!

Creating Neos & Flow
1

Hey everybody,

flow Flow 4.0 (and Neos 3.0), we want to switch from our own Fluid-Core-Base to Fluid-Standalone - and @christianm has done awesome work to get this to a working and ready state.

Now, on the last meters, we need your help to test and report your experiences.

Please report anything you find ASAP. Either on the pull requests (link at the bottom), or in this thread.

Thanks again Christian for your tireless work :slight_smile:
Sebastian

How to test?

Variant A: replace your global (neos development distribution) composer.json with the following file:

Afterwards, do the following:

composer update
rm -Rf Data/Temporary Configuration/PackageStates.php

The namespace for AbstractViewHelpers has changed and I haven’t added a migration yet, so if you try this with your own packages, make sure you adapt to Neos\FluidAdaptor…

Variant B (your own distribution)

adjust your composer.json as follows:

{
"repositories": [
    {
        "type": "vcs",
        "url": "https://github.com/kitsunet/flow-development-collection",
        "no-api": true
    },
    {
        "type": "vcs",
        "url": "https://github.com/kitsunet/neos-development-collection",
        "no-api": true
    },
    {
        "type": "vcs",
        "url": "https://github.com/kitsunet/form",
        "no-api": true
    },
    {
         "type": "vcs",
         "url": "https://github.com/kitsunet/setup",
         "no-api": true
    },
    {
         "type": "vcs",
         "url": "https://github.com/kitsunet/twitter-bootstrap",
         "no-api": true
    }
],
"require": {
    "neos/neos-development-collection": "dev-fluid-standalone as dev-master",
    "neos/flow-development-collection": "dev-fluid-standalone as dev-master",
    "typo3/twitter-bootstrap": "dev-standalone-fluid as dev-master",
    "typo3/setup": "dev-standalone-fluid as dev-master",
    "typo3/form": "dev-fluid-standalone as dev-master",

    ... your other dependencies here ...
}
}

Afterwards, do the following:

composer update
rm -Rf Data/Temporary Configuration/PackageStates.php

The namespace for AbstractViewHelpers has changed and I haven’t added a migration yet, so if you try this with your own packages, make sure you adapt to Neos\FluidAdaptor…

Links to the PRs

2 Likes
2

Hey,

I forgot to add that we’re hanging out on #project-fluid-coord on Slack :slight_smile: So feel free to join us there to give feedback as well!

All the best,
Sebastian

3

Thanks for putting this up!

So yes, this definitely needs a migration of course, like all packages that change namespaces. I haven’t done that yet. Apart from that this contains a lot of changes (some of them breaking) that I need to write together in one full change message.

If you find any problems with this please let me know ASAP, we should get this merged at the soonest possible time before namespace changes come into play and make this more difficult :slight_smile:

4

bump

5

Also this document might be helpful to have in here:

https://docs.google.com/document/d/1ezMpy9_eSYP9upLjiSQwGPl_brlPxUFH2zPecohzc2I/edit?usp=sharing

And these two things pending in Fluid itself:

6

So I tested this today, here is my feedback:

  • Had to use TYPO3Fluid\Fluid\Core\Rendering\RenderingContextInterface in one of the custom ViewHelpers instead of Neos\FluidAdaptor\Core\Rendering\RenderingContextInterface otherwise there is an “Mehtod incompatible” exception when calling the renderStatic method which is defined in
    `````Packages/Libraries/typo3fluid/fluid/src/Core/ViewHelper/AbstractViewHelper.php`

  • Also noticed the already mentioned Cycle ViewHelper problem

  • Could not get a certain project to run that had custom flow query operations, since I always got “No operation which satisfies the runtime constraints found for operationName” for all operations.
    Maybe the issue is not related to the standalone fluid, but to some other changes in master. Switching back to 2.3 everything is fine again.

Besides the last point (which might be unrelated), this looks very good already in the projects I tested. Good job :thumbsup:

7

THANKS!

I wonder how 1 was happening though, as our interface extends the mentioned one and just adds two additional getters. Right now I don’t see how that should be related. Maybe if you have a stacktrace of the specific error that would be helpful.

Cycle fix was merged AFAIK, so it’s just waiting for next bugfix release now.

The latter should be unrelated.

8

Ok, the current version gets rid of the

\Neos\FluidAdaptor\Core\Rendering\RenderingContextInterface

Instead always the original interface should be used. You can check for

\Neos\FluidAdaptor\Core\Rendering\FlowAwareRenderingContextInterface

and act accordingly to figure out if you can get an ObjectManager and/or ControllerContext.

This can and should obviously be done by a migration.

9

Thanks for the info!

Also got the latest version running on another site and everything looks good!

Error number 3 was resolved and 100% unrelated.

Since I did not run into issues that aren’t addressed yet in any of my tested projects I can officially give :thumbsup:

1 Like